D16147: Draw non-external text annotations with word wrap

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
aacid requested review of this revision.

REVISION SUMMARY
Instead of with wrap anywhere

BUGS: 398604

REPOSITORY
R223 Okular

BRANCH
master

REVISION DETAIL
https://phabricator.kde.org/D16147

AFFECTED FILES
ui/pagepainter.cpp

To: aacid
Cc: okular-devel, ngraham, aacid

[Albert Astals Cid]

aacid added subscribers: tobiasdeiminger, sander.
aacid added a comment.


I'm unconvinced whether this is actually better, but it's somehow similar to what poppler does, so maybe it makes sense?

REPOSITORY
R223 Okular

REVISION DETAIL
https://phabricator.kde.org/D16147

To: aacid
Cc: sander, tobiasdeiminger, okular-devel, ngraham, aacid

[Tobias Deiminger]

tobiasdeiminger added a comment.


"wrap anywhere" seems really a bit strange. I'd expect something like "wrap at word boundaries", "don't wrap but write across margins" or "enlarge rectangle on demand" from any sane tool. Qt::TextWordWrap would be fine for me.

Just tried it, Calligra Words uses word wrap for text frames by default, too.

REPOSITORY
R223 Okular

REVISION DETAIL
https://phabricator.kde.org/D16147

To: aacid
Cc: sander, tobiasdeiminger, okular-devel, ngraham, aacid

[Christoph Feck]

cfeck accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R223 Okular

BRANCH
master

REVISION DETAIL
https://phabricator.kde.org/D16147

To: aacid, cfeck
Cc: sander, tobiasdeiminger, okular-devel, ngraham, aacid

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
R223 Okular

REVISION DETAIL
https://phabricator.kde.org/D16147

To: aacid, cfeck
Cc: sander, tobiasdeiminger, okular-devel, ngraham, aacid