D15193: Add icons for the Trim Margins tools

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Okular.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
ngraham requested review of this revision.

REVISION SUMMARY
BUG: 397768
FIXED-IN: 18.12.0

TEST PLAN
[image goes here]

REPOSITORY
R223 Okular

BRANCH
trim-tool-icons (branched from master)

REVISION DETAIL
https://phabricator.kde.org/D15193

AFFECTED FILES
ui/pageview.cpp

To: ngraham, #okular
Cc: okular-devel, ngraham, aacid

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
R223 Okular

REVISION DETAIL
https://phabricator.kde.org/D15193

To: ngraham, #okular
Cc: okular-devel, ngraham, aacid

[Albert Astals Cid]

aacid added a comment.


I'm not really a fan of two consecutive entries having the same icon, but won't block this either.

Someone else likes nathan changes?

REPOSITORY
R223 Okular

REVISION DETAIL
https://phabricator.kde.org/D15193

To: ngraham, #okular
Cc: aacid, okular-devel, ngraham

[Nathaniel Graham]

ngraham added a comment.


Definitely open to different icon suggestions, FWIW. I looked but couldn't find anything better.

REPOSITORY
R223 Okular

REVISION DETAIL
https://phabricator.kde.org/D15193

To: ngraham, #okular
Cc: aacid, okular-devel, ngraham

[Nathaniel Graham]

ngraham added a comment.


Filed a bug requesting new icons that we can use here: https://bugs.kde.org/show_bug.cgi?id=401489

REPOSITORY
R223 Okular

REVISION DETAIL
https://phabricator.kde.org/D15193

To: ngraham, #okular
Cc: aacid, okular-devel, ngraham, darcyshen

[Nathaniel Graham]

ngraham planned changes to this revision.

REPOSITORY
R223 Okular

REVISION DETAIL
https://phabricator.kde.org/D15193

To: ngraham, #okular
Cc: aacid, okular-devel, ngraham, darcyshen